fix: handle non-file URI schemes gracefully in shellcheck linting#1371
Merged
Conversation
When opening files via virtual filesystems (WebDAV, kio-fuse, etc.), the document URI may not use the file: scheme. Previously, calling fileURLToPath() on such URIs would throw ERR_INVALID_URL_SCHEME. This change adds a safeFileURLToPath helper that: - Returns the file path for valid file: URIs - Returns null for non-file URIs or invalid URIs - Allows linting to proceed without the document directory in source paths Closes bash-lsp#1370
Collaborator
|
Thanks, can you just run |
skovhus
approved these changes
Jan 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 80.55% 80.59% +0.03%
==========================================
Files 29 29
Lines 1502 1510 +8
Branches 371 373 +2
==========================================
+ Hits 1210 1217 +7
- Misses 234 235 +1
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for linting error when opening files via virtual filesystems (WebDAV, kio-fuse, etc.).
Closes #1370
Problem
When using editors like Kate on KDE Plasma with WebDAV-mounted files, the document URI uses a non-
file:scheme (e.g.,kio-fuse://...). The linter would throw:This occurred because
fileURLToPath()from Node.js only acceptsfile:URIs.Solution
Added a
safeFileURLToPathhelper function that:file:protocolfile:URIsnullfor non-file:URIs or invalid URIsWhen the document path cannot be determined, linting proceeds without adding the document's directory to the source paths. This means ShellCheck's
--source-pathwill only include explicitly configured paths, but linting will still work for the document content itself.Testing
Added a test case to verify that non-
file:URI schemes are handled gracefully without throwing errors.Notes
file:URIs - it just won't include the document's directory in the source search pathsourcePathsin their LSP client settings if needed